Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump OkHttp to 3.14.9 #4296

Closed
wants to merge 1 commit into from
Closed

Conversation

manusa
Copy link
Member

@manusa manusa commented Jul 22, 2022

Description

deps: bump OkHttp to 3.14.9

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Copy link
Member

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a 3.14.9 bundle too.

@manusa
Copy link
Member Author

manusa commented Jul 22, 2022

We need a 3.14.9 bundle too.

I upgraded the ServiceMix bundle dependency to 3.14.1_2, but it's based on 3.14.1. I'm unsure of the behavior this might cause.

@oscerd
Copy link
Member

oscerd commented Jul 22, 2022

It might work, but some of the problems will show up only in OSGi runtime at runtime.. The best solution is going ahead with this PR. We'll need to add a 3.14.9 bundle to the next Servicemix bundles release and then upgrade here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rohanKanojia rohanKanojia requested a review from shawkins July 22, 2022 14:35
@manusa manusa requested review from rohanKanojia and sunix July 25, 2022 07:22
@manusa manusa self-assigned this Jul 25, 2022
@manusa manusa added this to the 6.1.0 milestone Jul 25, 2022
@manusa manusa added the wip label Aug 10, 2022
@mkdev0101
Copy link

Any plans to upgrade to 4.10.x which has fix for CVE PRISMA-2022-0239 (square/okhttp#6738) ?

@rohanKanojia
Copy link
Member

@mkdev0101 : OkHttp v4 is based on kotlin which we want to avoid. Please read #4290 (comment) for more details

@manusa manusa modified the milestones: 6.1.0, 6.2.0 Aug 31, 2022
@manusa manusa removed the wip label Sep 5, 2022
@manusa
Copy link
Member Author

manusa commented Sep 5, 2022

Bundle version has been updated too (3.14.9_1)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manusa manusa added the wip label Sep 5, 2022
@manusa manusa modified the milestones: 6.2.0, 6.x Oct 11, 2022
@manusa manusa mentioned this pull request May 16, 2023
@manusa
Copy link
Member Author

manusa commented May 29, 2023

Considering Quarkus no longer depends on the OkHttp client (at least for production), we should move forward to use OkHttp 4 instead.

Closing this PR and #5134 in favor of #2632

@manusa manusa closed this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants