-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #3334: adding basic support for server side apply #3937
Conversation
On the UserAgent. It looks like we are looking for a property key of "fabric8-kubernetes-client/" + Version.clientVersion() - that seems more like it should be the default value if not set in the Config. |
Agree on the second, configurable value with default to |
# Conflicts: # kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/Config.java
Applied that change as part of this pr - fabric8-kubernetes-client/$version |
Thanks, please add some doc about this in CHEATSHEET as well. This has been requested multiple times |
also making updates for client building and generics
SonarCloud Quality Gate failed. |
Sure. Also updated some other cheatsheet information related to creating clients and generic types. |
Description
Adds basic support for server side apply via the additional patch type requested with #3334 - any higher level support for apply will be addressed under the other apply / createOrReplace issues.
This does ensure the fieldManager is set (fabric8 by default) and that the managedFields are cleared.
ServerSideIT shows the usage - typically all creates/updates would be done as server side apply. If you don't create the resource with server side apply any subsequent usage of server side apply will throw an exception - which you can workaround by including the force flag.
We may want to consider defaulting the user agent to fabric8 - if you create a resource using create, it will set the fieldManager to okhttp.
Type of change
test, version modification, documentation, etc.)
Checklist