chore: bump sundrio to 0.50.1 #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
iocanel
force-pushed
the
sundrio-0.50.1
branch
2 times, most recently
from
21d68b4 to
ba8584f
Compare
oscerd
approved these changes
Sep 2, 2021
metacosm
requested changes
Sep 3, 2021
pom.xml
Outdated
| @@ -79,7 +79,7 @@ | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
|
|
|||
| <!-- Core versions --> | |||
| <sundrio.version>0.40.1</sundrio.version> | |||
| <sundrio.version>0.50.0</sundrio.version> | |||
There was a problem hiding this comment.
Shouldn't this be 0.50.1, actually?
iocanel
force-pushed
the
sundrio-0.50.1
branch
from
ba8584f to
65620a5
Compare
metacosm
reviewed
Sep 3, 2021
| @@ -749,7 +755,7 @@ | |||
| <groupId>io.sundr</groupId> | |||
| <artifactId>sundr-maven-plugin</artifactId> | |||
| <version>${sundrio.version}</version> | |||
| <dependencies> | |||
| <!--dependencies> | |||
There was a problem hiding this comment.
Do we need to keep that code commented out? Can't we just remove it?
|
SonarCloud Quality Gate failed. |
11 tasks
metacosm
approved these changes
Sep 3, 2021
manusa
approved these changes
Sep 6, 2021
rohanKanojia
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request bumps sundrio to 0.50.1.
Important things about this version upgrade:
So velocity is now explicitly added as a shaded uberjar:
io.sundr:sundr-codegen-velocity-nodeps.A potential lighter alternative that uses
String Template 4is available at:io.sundr:sundr-codegen-st4-nodeps. So, we might consider converting at some point.