-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document workaround for Kubernetes IPv6 Clusters using KubernetesClient #3343
Merged
manusa
merged 1 commit into
fabric8io:master
from
rohanKanojia:doc/kubernetes-client-with-k8s-ipv6
Jul 26, 2021
Merged
Document workaround for Kubernetes IPv6 Clusters using KubernetesClient #3343
manusa
merged 1 commit into
fabric8io:master
from
rohanKanojia:doc/kubernetes-client-with-k8s-ipv6
Jul 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manusa
reviewed
Jul 23, 2021
manusa
reviewed
Jul 23, 2021
manusa
reviewed
Jul 23, 2021
README.md
Outdated
@@ -36,6 +36,7 @@ This client provides access to the full [Kubernetes](http://kubernetes.io/) & | |||
- [Kubernetes and Red Hat OpenShift Compatibility Matrix](#compatibility-matrix) | |||
- [Kubernetes Client CHEAT SHEET](https://github.com/fabric8io/kubernetes-client/blob/master/doc/CHEATSHEET.md) | |||
- [Kubectl Java Equivalents](#kubectl-java-equivalents) | |||
- [FAQs](./doc/Faq.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename the file to ./doc/FAQ.md
manusa
reviewed
Jul 23, 2021
@@ -0,0 +1,40 @@ | |||
# Using KubernetesClient with IPv6 based Kubernetes Clusters | |||
|
|||
Right now Fabric8 Kubernetes Client doesn't work with IPv6 based Kubernetes Clusters due to an issue in OkHttp[square/okhttp#5889](https://github.com/square/okhttp/pull/5889). Fabric8 Kubernetes Client is right now dependent on OkHttp 3.x; unfortunately we can't upgrade to OkHttp 4.x due to it being now based on Kotlin, see [square/okhttp#4723](https://github.com/square/okhttp/issues/4723). We have decided not to upgrade to OkHttp 4.x. Until we find an alternative HTTP library for KubernetesClient, we suggest you to resolve this issue by excluding okhttp dependency coming from KubernetesClient jar and adding your own direct 4.x OkHttp dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Right now Fabric8 Kubernetes Client doesn't work with IPv6 based Kubernetes Clusters due to an issue in OkHttp[square/okhttp#5889](https://github.com/square/okhttp/pull/5889). Fabric8 Kubernetes Client is right now dependent on OkHttp 3.x; unfortunately we can't upgrade to OkHttp 4.x due to it being now based on Kotlin, see [square/okhttp#4723](https://github.com/square/okhttp/issues/4723). We have decided not to upgrade to OkHttp 4.x. Until we find an alternative HTTP library for KubernetesClient, we suggest you to resolve this issue by excluding okhttp dependency coming from KubernetesClient jar and adding your own direct 4.x OkHttp dependencies: | |
Right now Fabric8 Kubernetes Client doesn't work with IPv6 based Kubernetes Clusters due to an issue in OkHttp [square/okhttp#5889](https://github.com/square/okhttp/pull/5889). The issue is solved for OkHttp 4, but Fabric8 Kubernetes Client depends on OkHttp 3.x. ; unfortunately we can't upgrade to OkHttp 4.x due to it being now based on Kotlin, see [square/okhttp#4723](https://github.com/square/okhttp/issues/4723). | |
We have decided not to upgrade to OkHttp 4.x, because it's based on Kotilin ([square/okhttp#4723](https://github.com/square/okhttp/issues/4723)) and this might be an issue for downstream and dependent projects . | |
We're still discussing a proper replacement for OkHttp (#2764, #2632). In the meantime you can switch to use OkHttp 4.x in your project by configuring 3.x exclusions and adding your own direct 4.x OkHttp dependencies ([since it's binary compatible](https://github.com/fabric8io/kubernetes-client/issues/2632#issuecomment-748434878)): |
rohanKanojia
force-pushed
the
doc/kubernetes-client-with-k8s-ipv6
branch
2 times, most recently
from
July 23, 2021 15:19
528d60c
to
49b9a8f
Compare
Add a section in documentation which informs users about excluding OkHttp dependency from KubernetesClient and adding a direct OkHttp 4 dependency in order to resolve OkHttp 3.x bug Signed-off-by: Rohan Kumar <[email protected]>
manusa
force-pushed
the
doc/kubernetes-client-with-k8s-ipv6
branch
from
July 26, 2021 05:11
49b9a8f
to
3db5d13
Compare
Kudos, SonarCloud Quality Gate passed! |
manusa
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a section in documentation which informs users about excluding
OkHttp dependency from KubernetesClient and adding a direct OkHttp 4
dependency in order to resolve OkHttp 3.x bug
Related to #2632
Signed-off-by: Rohan Kumar [email protected]
Type of change
test, version modification, documentation, etc.)
Checklist