-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Restore method removed without prior notice #2898
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a admin/maintainer but I approve :-) thanks!
I think we would need to update CRD registering logic too to be able to register same pojo for different versions of Custom Resource depending upon OperationContext, right now we're picking group and version from annotations. If someone tries to override this with custom CRDContext, this might fail during watch : Lines 342 to 345 in 698eda1
|
...netes-client/src/main/java/io/fabric8/kubernetes/client/informers/SharedInformerFactory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart the Deprecated comment.
e24be5d
to
b0db155
Compare
SonarCloud Quality Gate failed. |
Description
Method removed in #2667 is still used by dependent projects (cc @ppatierno)
Restored the missing method and added a
@Depreaction
annotation yet to be discussed.Relates to #2738
Type of change
test, version modification, documentation, etc.)
Checklist