Fix #2802: Kubernetes Mock Server Crud Mode should reject invalid Kubernetes resources #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Mar 11, 2021
manusa
reviewed
Mar 12, 2021
...er-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/KubernetesCrudDispatcher.java
Outdated
Show resolved
Hide resolved
manusa
reviewed
Mar 12, 2021
...er-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/KubernetesCrudDispatcher.java
Outdated
Show resolved
Hide resolved
…valid Kubernetes resources Right now when a resource with no metadata is created, instead of throwing KubernetesClientException, we're throwing a NullPointerException here: KubernetesAttributesExtractor.extractMetadataAttributes:L154 KubernetesMockServer should validate whether object sent in request body contains metadata or not Note that this doesn't solve your issue when your using KubernetesMockServer in expectations mode since you set what you'll be getting as response by yourself
rohanKanojia
force-pushed
the
pr/issue2802
branch
from
3192e60 to
003ea4a
Compare
|
SonarCloud Quality Gate failed. |
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2802
Right now when a resource with no metadata is created, instead of throwing KubernetesClientException, we're throwing a
NullPointerException here:
KubernetesAttributesExtractor.extractMetadataAttributes:L154
KubernetesMockServer should validate whether object sent in the request body contains metadata or not
Note that this doesn't solve your issue when you're using
KubernetesMockServer in expectations mode since you set what you'll be
getting as response to be received by yourself
Description
Type of change
test, version modification, documentation, etc.)
Checklist