Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2662: Allow option to containerize Go Model Schema generation builds #2791

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Fix #2662: Allow option to containerize Go Model Schema generation builds #2791

merged 4 commits into from
Mar 1, 2021

Conversation

rohanKanojia
Copy link
Member

Fix #2662

Added a bash script for doing Go Model generation Builds inside a docker
container. Go Build and schema generation are done inside a container
and copied to host folders afterwards

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia force-pushed the pr/issue2662 branch 3 times, most recently from 2c52609 to d5aee0b Compare February 5, 2021 20:11
@rohanKanojia rohanKanojia marked this pull request as ready for review February 8, 2021 07:14
rohanKanojia and others added 4 commits March 1, 2021 12:46
@rohanKanojia @manusa
Fix fabric8io#2662: Allow option to containerize Go Model Schema gene…
1bac484 
…ration builds

Added a bash script for doing Go Model generation Builds inside a docker
container. Go Build and schema generation are done inside a container
and copied to host folders afterwards
@manusa
refactor: Docker kubernetes-model-generator simplified
c225e4d
@rohanKanojia @manusa
Add check in Go Build workflow to check for no schema modification
57e36b3
@rohanKanojia @manusa
Move Go Build schema modification check to a different step
49ea23e
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@manusa manusa merged commit ddd2978 into fabric8io:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow option to containerize Go Model Schema generation builds
2 participants
@rohanKanojia @manusa