-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add isMarkedForDeletion and finalizer-related methods #2607
Conversation
Can one of the admins verify this patch? |
These seem to not be specific for CustomResources but for all cluster types. Maybe add it as part of a utility class? Or even as a default method in the HasMetadata interface? public interface HasMetadata extends KubernetesResource {
ObjectMeta getMetadata();
void setMetadata(ObjectMeta metadata);
String getKind();
String getApiVersion();
void setApiVersion(String version);
default boolean isMarkedForDeletion() {
return StringUtils.isNotBlank(getMetadata().getDeletionTimestamp());
}
} |
Could you please add Javadocs for these new methods? |
I'm afraid formatting in the license header breaks the check. Please use the unmodified/unformatted header. |
How can I figure out which files are causing the issue? |
In your case HasMetadata (now contains |
*/ | ||
package io.fabric8.kubernetes.api.model; | ||
|
||
import org.junit.Test; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import org.junit.Test; | |
import org.junit.jupiter.api.Test; |
Kudos, SonarCloud Quality Gate passed! 0 Bugs 83.3% Coverage The version of Java (1.8.0_275) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11. |
Description
Adds convenience methods on CustomResource. Not sure if it makes sense to add them at that level?
Type of change
test, version modification, documentation, etc.)
Checklist