Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2514: SharedIndexInformer watches only pods of its own namespace when run in the cluster #2536

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Oct 9, 2020

Fix #2514

Introduced a boolean field namespaceFromGlobalConfig in OperationContext with which we would be able to distinguish whether namespace is set from Global Configuration or Operation's context

This is also related to:

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia force-pushed the pr/informer-inside-pod branch from 77f74db to 1f81f9c Compare October 9, 2020 18:38
@rohanKanojia rohanKanojia force-pushed the pr/informer-inside-pod branch 2 times, most recently from b438290 to 47c9a9e Compare October 9, 2020 19:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 9 Code Smells

25.5% 25.5% Coverage
0.8% 0.8% Duplication

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@rohanKanojia rohanKanojia requested a review from manusa October 27, 2020 14:50
@rohanKanojia rohanKanojia force-pushed the pr/informer-inside-pod branch from 47c9a9e to c21b135 Compare November 9, 2020 19:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 9 Code Smells

22.3% 22.3% Coverage
0.8% 0.8% Duplication

warning The version of Java (1.8.0_272) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11.
Read more here

@manusa
Copy link
Member

manusa commented Nov 10, 2020

[merge]

1 similar comment
@rohanKanojia
Copy link
Member Author

[merge]

@fusesource-ci fusesource-ci merged commit aaabfee into fabric8io:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants