Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2292: Update BaseOperation#createOrReplace() #2372

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Fix #2292: Update BaseOperation#createOrReplace() #2372

merged 1 commit into from
Jul 31, 2020

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jul 27, 2020 •
edited
Loading

Description

Fix #2292

  • Updated BaseOperation#createOrReplace to fallback to replace() after doing create() rather than get() -> replace()
  • Updated ResourceCompare#equals() to only compare entities present in provided resource when compared with
    resource from cluster.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia requested a review from manusa July 28, 2020 05:37
@rohanKanojia
Copy link
Member Author

retest this please

@manusa manusa self-requested a review July 29, 2020 08:04
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

45.7% 45.7% Coverage
0.0% 0.0% Duplication

@manusa
Copy link
Member

manusa commented Jul 31, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 14cae94 into fabric8io:master Jul 31, 2020
This was referenced Jul 31, 2020
Closed
Closed
Closed
@manusa manusa mentioned this pull request Aug 3, 2020
Closed
This was referenced Sep 1, 2020
Closed
Closed
@manusa manusa mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update BaseOperation#createOrReplace
4 participants
@rohanKanojia @manusa @oscerd @fusesource-ci