-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CSI Volume Snapshot extension #2356
Conversation
Can one of the admins verify this patch? |
ok to test |
Conflicting with #2324, in particular https://github.com/fabric8io/kubernetes-client/pull/2324/files#diff-77557acf7ffeaed157f7c3b35bc4a900L1001-R1001 |
812668b
to
a3057bb
Compare
Reformat, introduce ExtensionAdapterSupport to avoid duplication Remove unused ApiVersionUtil Fix license
a3057bb
to
1756b0c
Compare
@Vlatombe: Is this pull request ready for review? If yes, could you please remove your PR being marked as draft? |
@Vlatombe : any idea when this PR will be ready? |
SonarCloud Quality Gate failed. 0 Bugs |
[merge] |
Thanks for merging this. @rohanKanojia - Any idea when can this be cut into a release? I have been testing the client using the SNAPSHOT version, but will be good to start using the official client. |
If everything goes well, I think we should be able to release by the end of next week |
@rohanKanojia : I see that 4.11 is release now, how do I used the volumesnapshot-client from 4.11? I added this dependency 'io.fabric8:kubernetes-client:4.11.0' but I don't see volumesnapshot in there. I also added 'io.fabric8:volumesnapshot-client:4.11.0' but it looks like the volumesnapshot-client might not be release. |
It's not a part of kubernetes-client, it's added as an extension. You can use it after adding this dependency:
https://search.maven.org/artifact/io.fabric8/volumesnapshot-client/4.11.0/bundle |
Thanks, that worked! |
Description
Add DSL for Volume Snapshots
Type of change
test, version modification, documentation, etc.)
Checklist