Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CSI Volume Snapshot extension #2356

Merged
merged 8 commits into from
Aug 20, 2020

Conversation

Vlatombe
Copy link
Contributor

Description

Add DSL for Volume Snapshots

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@rohanKanojia
Copy link
Member

ok to test

@Vlatombe
Copy link
Contributor Author

@Vlatombe Vlatombe force-pushed the csi-volume-snapshot branch from 812668b to a3057bb Compare July 17, 2020 08:47
Reformat, introduce ExtensionAdapterSupport to avoid duplication

Remove unused ApiVersionUtil

Fix license
@Vlatombe Vlatombe force-pushed the csi-volume-snapshot branch from a3057bb to 1756b0c Compare July 17, 2020 08:49
@rohanKanojia
Copy link
Member

@Vlatombe: Is this pull request ready for review? If yes, could you please remove your PR being marked as draft?

@manusa manusa linked an issue Aug 3, 2020 that may be closed by this pull request
@ajaykmis
Copy link

ajaykmis commented Aug 7, 2020

@Vlatombe : any idea when this PR will be ready?

@Vlatombe Vlatombe marked this pull request as ready for review August 10, 2020 07:15
@rohanKanojia rohanKanojia requested review from manusa and iocanel August 10, 2020 09:02
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 20 Code Smells

0.0% 0.0% Coverage
1.2% 1.2% Duplication

@manusa
Copy link
Member

manusa commented Aug 20, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 559f594 into fabric8io:master Aug 20, 2020
@Vlatombe Vlatombe deleted the csi-volume-snapshot branch August 20, 2020 09:07
@ajaykmis
Copy link

Thanks for merging this. @rohanKanojia - Any idea when can this be cut into a release? I have been testing the client using the SNAPSHOT version, but will be good to start using the official client.

@rohanKanojia
Copy link
Member

If everything goes well, I think we should be able to release by the end of next week

@ajaykmis
Copy link

@rohanKanojia : I see that 4.11 is release now, how do I used the volumesnapshot-client from 4.11? I added this dependency 'io.fabric8:kubernetes-client:4.11.0' but I don't see volumesnapshot in there. I also added 'io.fabric8:volumesnapshot-client:4.11.0' but it looks like the volumesnapshot-client might not be release.

@rohanKanojia
Copy link
Member

It's not a part of kubernetes-client, it's added as an extension. You can use it after adding this dependency:

<dependency>
  <groupId>io.fabric8</groupId>
  <artifactId>volumesnapshot-client</artifactId>
  <version>4.11.0</version>
</dependency>

https://search.maven.org/artifact/io.fabric8/volumesnapshot-client/4.11.0/bundle

@ajaykmis
Copy link

Thanks, that worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for VolumeSnapshots in 1.17
7 participants