Test and fix for the wrong "Kind" declared on KubernetesListHandler

[ahgittin]

Description

This PR changes KubernetesListHandler.getKind() from returning "Service" to returning "List". The latter is what KubernetesList.getKind() returns, and the former causes the resulting ResourceHandler.Key to be identical to what is computed for ServiceHandler, meaning Handlers.of(key) can return the wrong handler.

In practice the problem noted above can cause the Kubernetes client to fail when working with kind: Service YAML manifests, in some circumstances. This was observed under OSGi using the DefaultKubernetesClient. Handlers.of(<Service,v1>) returned the KubernetesListHandler which subsequently threw the following exception:

Failed after 466ms: io.fabric8.kubernetes.api.model.Service cannot be cast to io.fabric8.kubernetes.api.model.KubernetesList
java.lang.ClassCastException: io.fabric8.kubernetes.api.model.Service cannot be cast to io.fabric8.kubernetes.api.model.KubernetesList
	at io.fabric8.kubernetes.client.handlers.KubernetesListHandler.edit(KubernetesListHandler.java:39)
	at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.acceptVisitors(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:331)
	at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.createOrReplace(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:248)
	at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.createOrReplace(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:64)
	at ...

The problem is not usually observed because KubernetesListHandler is not registered as a service in POJO, but it is under OSGi, and of course because Handlers keeps a map based on the key, whether the problem actually happens depends which of the two handlers was registered last.

This PR also includes a test which asserts there are no conflicts among the stock handlers, which fails prior to the fix and passes subsequently.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[centos-ci]

Can one of the admins verify this patch?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
2 Code Smells

100.0% Coverage
0.0% Duplication

[rohanKanojia]

ok to test

[rohanKanojia]

@ahgittin : Thanks for your contribution 👍. There are two sonar code smells, I think they can be easily addressed

[ahgittin]

Cheers. Yes I looked at the alleged code smells but didn't think they were relevant - one is code I didn't touch and the other is it complaining a test method is public which it has to be normally. If I'm wrong and I should do something about them I'd appreciate a steer.

…

On Wed, 8 Jul 2020, 17:15 Rohan Kumar, ***@***.***> wrote: @ahgittin <https://github.com/ahgittin> : Thanks for your contribution 👍 There are two sonar code smells <https://sonarcloud.io/project/issues?id=fabric8io_kubernetes-client&pullRequest=2336&resolved=false&types=CODE_SMELL&q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc> I think they can be easily addressed — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2336 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZHHELNMID3RRPG4S6LS3R2SLR3ANCNFSM4OT5WVOQ> .

[rohanKanojia]

[merge]