Adding extension for JUnit5 support #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
Jun 30, 2020
|
ok to test |
manusa
approved these changes
Jul 1, 2020
|
@piomin: Could you please add some Javadocs in the added classes about how they fit in the existing mock framework for the benefit of future developers? Also, I would appreciate if you could add some docs about usage too. |
rohanKanojia
added
the
changelog missing
|
Kudos, SonarCloud Quality Gate passed!
|
|
@rohanKanojia I added javadocs, entry in changelog and information in the readme.md file. I also don't think that error 'ci/circleci: OPENSHIFT_3.11.0 — Your tests failed on CircleCI' has anything with to do with my changes. |
rohanKanojia
approved these changes
Jul 1, 2020
|
[merge] |
manusa
removed
the
changelog missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.