Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2143: Support for v1, v2beta1 and v2beta2 HorizontalPodAutoscaler resources #2169

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix #2143: Support for v1, v2beta1 and v2beta2 HorizontalPodAutoscaler resources #2169

merged 1 commit into from
Apr 28, 2020

Conversation

rohanKanojia
Copy link
Member

Related to #2143 #2015

@rohanKanojia rohanKanojia requested a review from manusa April 28, 2020 10:00
@manusa
Copy link
Member

manusa commented Apr 28, 2020 •
edited
Loading

Check these https://sonarcloud.io/project/issues?id=fabric8io_kubernetes-client&pullRequest=2169&resolved=false&types=CODE_SMELL
I think we can fix most of them.

@rohanKanojia rohanKanojia force-pushed the pr/issue2015 branch 2 times, most recently from edd6680 to 39948ba Compare April 28, 2020 13:17
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

4.2% 4.2% Coverage
0.0% 0.0% Duplication

@rohanKanojia
Copy link
Member Author

[merge]

@fusesource-ci fusesource-ci merged commit 791fbac into fabric8io:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohanKanojia @manusa @oscerd @fusesource-ci