Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1961: Two SharedInformer issues related to kube-apiserver unavailable and relisting #2022

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Fix #1961: Two SharedInformer issues related to kube-apiserver unavailable and relisting #2022

merged 3 commits into from
Mar 4, 2020

Conversation

rohanKanojia
Copy link
Member

Fix #1961

@rohanKanojia rohanKanojia removed the wip label Feb 27, 2020
manusa
manusa approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rohanKanojia
Copy link
Member Author

[merge]

1 similar comment
@rohanKanojia
Copy link
Member Author

[merge]

rohanKanojia and others added 3 commits February 27, 2020 16:15
@rohanKanojia
Fix fabric8io#1961: Two SharedInformer issues related to kube-apiserv…
cc3c0d7 
…er unavailable and relisting

+ relist when 410 is received
+ set HasSynced() to false when Reflector faces error
@manusa @rohanKanojia
refactor: Refactored ProcessorListener and RefelectorRunnable
8ba75ea 
Fixed license
@rohanKanojia
Added SharedInformerEventListener in SharedInformerFactory for handli…
45604e2 
…ng exceptions

SharedInformerFactory would have a method called addSharedInformerEventListener() which would recieve
an interface to handle failures.
@rohanKanojia
Copy link
Member Author

[merge]

@fusesource-ci fusesource-ci merged commit 40959b9 into fabric8io:master Mar 4, 2020
@DaspawnW DaspawnW mentioned this pull request Mar 13, 2020
Merged
@rohanKanojia rohanKanojia mentioned this pull request Apr 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

@iocanel iocanel Awaiting requested review from iocanel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two SharedInformer issues related to kube-apiserver unavailable and relisting
4 participants
@rohanKanojia @manusa @oscerd @fusesource-ci