Fix #1805: Unable to create Template on OCP4 #1956
Merged
+64
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/issue1804
branch
from
68cc1d6 to
3b2a217
Compare
|
retest this please |
oscerd
approved these changes
Jan 17, 2020
Modified BackwardCompatibilityInterceptor for handling /oapi
failures in case of OpenShift
rohanKanojia
force-pushed
the
pr/issue1804
branch
from
3b2a217 to
4805c84
Compare
rohanKanojia
changed the title
manusa
approved these changes
Jan 21, 2020
|
[merge] |
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this pull request
Jul 28, 2020
Looks like code added in fabric8io#1956 BackwardCompatibilityInterceptor wasn't handling /oapi failures properly. Fix BackwardCompatibilityInterceptor logic for routing to OpenShift 3 /oapi/v1 endpoints when OpenShift 4 /apis/{group}/v1 endpoints not found. Also added some tests to assert desired behavior
11 tasks
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this pull request
Jul 28, 2020
Looks like code added in fabric8io#1956 BackwardCompatibilityInterceptor wasn't handling /oapi failures properly. Fix BackwardCompatibilityInterceptor logic for routing to OpenShift 3 /oapi/v1 endpoints when OpenShift 4 /apis/{group}/v1 endpoints not found. Also added some tests to assert desired behavior
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this pull request
Jul 31, 2020
Looks like code added in fabric8io#1956 BackwardCompatibilityInterceptor wasn't handling /oapi failures properly. Fix BackwardCompatibilityInterceptor logic for routing to OpenShift 3 /oapi/v1 endpoints when OpenShift 4 /apis/{group}/v1 endpoints not found. Also added some tests to assert desired behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1805
Modified BackwardCompatibilityInterceptor for handling /oapi
failures in case of OpenShift