Fix #1859 - Pass caller's propagation-policy/cascade options to the underlying replicaset when deleting a deployment #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the underlying replicaset when deleting a deployment
|
Can one of the admins verify this patch? |
|
You can try asserting value of |
|
ok to test |
rohanKanojia
approved these changes
Nov 20, 2019
oscerd
approved these changes
Nov 20, 2019
the code deletes the replicaset then the deployment. getLastRequest gives me the delete of the deployment. The mock framework doesn't seem to allow me to access the request that came before it which is what I need to validate my change. |
|
ah, sorry. I misunderstood your statement. Yeah, I'm also not sure how to get second last request. |
manusa
approved these changes
Nov 20, 2019
|
retest this please |
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried and failed to write a unit test for this change. The mock server allows you to set up expectations about a
server.expect().delete().withPath()..., but there seem to be no way to actually set an expectation about the request body (to validate the delete options). I noticed theserver.getLastRequest()exists, but this doesn't help me in this case.getLastRequest()gives me the delete for the deployment, I need to access the penultimate which would be the DELETE for my replicaset.