Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readd missing inPipe #1500

Merged
merged 2 commits into from
Apr 22, 2019
Merged

Readd missing inPipe #1500

merged 2 commits into from
Apr 22, 2019

Conversation

carlossg
Copy link
Contributor

@carlossg carlossg commented Apr 22, 2019 •
edited
Loading

@carlossg
Readd missing inPipe
3633f77 
Was inadvertently removed in ded7e13
@centos-ci
Copy link

Can one of the admins verify this patch?

carlossg referenced this pull request Apr 22, 2019
@iocanel
refactor: Introduce OperationContext, to limit the use of reflection.
ded7e13
@carlossg carlossg mentioned this pull request Apr 22, 2019
Merged
@rohanKanojia rohanKanojia requested review from iocanel and oscerd April 22, 2019 10:43
@rohanKanojia rohanKanojia added the changelog missing A line to changelog.md regarding the change is not added label Apr 22, 2019
rohanKanojia
rohanKanojia approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, could you please add a line to changelog so that we can proceed to merge it?

@devang-gaur devang-gaur self-requested a review April 22, 2019 12:13
@rohanKanojia rohanKanojia merged commit 80b9cd7 into fabric8io:master Apr 22, 2019
@carlossg carlossg deleted the redirectingInput branch April 23, 2019 16:01
@Vlatombe
Copy link
Contributor

Vlatombe commented Jun 7, 2019

Hey @rohanKanojia , this issue is blocking us to upgrade the kubernetes-client, and it has been a while since the latest release. Would be it possible for you to schedule a new release?

@rohanKanojia
Copy link
Member

@Vlatombe : Hi @Vlatombe, apologies for delay in release. I've released a new version, it can be found on maven central v4.3.0

@Vlatombe
Copy link
Contributor

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@devang-gaur devang-gaur devang-gaur approved these changes

@iocanel iocanel Awaiting requested review from iocanel

@oscerd oscerd Awaiting requested review from oscerd

Assignees
No one assigned
Labels
changelog missing A line to changelog.md regarding the change is not added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlossg @centos-ci @Vlatombe @rohanKanojia @devang-gaur