Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: First draft of exposing port-forward via service DSL. #1453

Merged
merged 2 commits into from
Mar 27, 2019
Merged

feat: First draft of exposing port-forward via service DSL. #1453

merged 2 commits into from
Mar 27, 2019

Conversation

iocanel
Copy link
Member

@iocanel iocanel commented Mar 23, 2019 •
edited by rohanKanojia
Loading

Fixes #1447

@centos-ci
Copy link

Can one of the admins verify this patch?

@iocanel iocanel requested a review from rohanKanojia March 23, 2019 11:38
@rohanKanojia rohanKanojia added the changelog missing A line to changelog.md regarding the change is not added label Mar 25, 2019
rohanKanojia
rohanKanojia approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rohanKanojia rohanKanojia requested a review from oscerd March 25, 2019 16:08
@rohanKanojia
Copy link
Member

@iocanel : Could you please add an example/test for this?

@iocanel iocanel removed the changelog missing A line to changelog.md regarding the change is not added label Mar 26, 2019
@iocanel
Copy link
Member Author

iocanel commented Mar 26, 2019

@iocanel : Could you please add an example/test for this?

Port forwarding is an area where we are lacking tests, even in the pod dsl.
Its no surprise as its pretty complicated and I am not sure if we can even mock it.

We should find a solution, but I wouldn't hold the PR for that.

@rohanKanojia
Copy link
Member

@iocanel 🙏

@rohanKanojia
Copy link
Member

[merge]

@fusesource-ci fusesource-ci merged commit 53d1b16 into fabric8io:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iocanel @centos-ci @rohanKanojia @oscerd @fusesource-ci