refactor: Introduce OperationContext, to limit the use of reflection. #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Darn tests are failing... :( |
rohanKanojia
force-pushed
the
reflection
branch
2 times, most recently
from
e06122e to
9a932ac
Compare
| @@ -34,6 +35,7 @@ | |||
| import static org.junit.Assert.assertEquals; | |||
| import static org.junit.Assert.assertNotNull; | |||
|
|
|||
| @Ignore | |||
There was a problem hiding this comment.
Ignored that test because it was hunging forever and forgot to deal with it.
+ Wait till resource is deleted from cluster in failing tests
rohanKanojia
force-pushed
the
reflection
branch
from
9a932ac to
66184ba
Compare
| */ | ||
| package io.fabric8.kubernetes.client.dsl.base; | ||
|
|
||
| import io.fabric8.kubernetes.api.model.HasMetadata; |
There was a problem hiding this comment.
This guy is super picky @iocanel :-D
| return new CustomResourceOperationContext(client, config, plural, namespace, name, apiGroupName, apiGroupVersion, cascading,item, labels, labelsNot, labelsIn, labelsNotIn, fields, resourceVersion, reloadingFromServer, gracePeriodSeconds, crd, type, listType, doneableType); | ||
| } | ||
|
|
||
| public CustomResourceOperationContext withRolling(boolean rolling) { |
There was a problem hiding this comment.
I might be wrong here, but can Custom resources can be rollable too 😲
There was a problem hiding this comment.
I don't think so.
Besides these methods doesn't seem to have any effect at all. I'll remove them.
…y to decouple tests from internals.
rohanKanojia
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request, eliminates constructing objects using reflection.
Also simplifies the constructors of operation object by using a single argument.
There are still places that are using reflections, that will be eliminated later in the process).