Determine kubernetes service host and port from environment if available #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a note to the CHANGELOG |
oscerd
approved these changes
May 30, 2018
|
ok to test |
piyush-garg
approved these changes
May 30, 2018
|
Thanks a lot, @Vlatombe for the PR. Can you please also squash the commits. |
…ble. This can differ from kubernetes.default.svc in some occasions. Uses the same logic as the go client (https://github.com/kubernetes/client-go/blob/master/rest/config.go#L313-L336)
Vlatombe
force-pushed
the
determine-master-url-from-environment
branch
from
db29e99 to
402bc74
Compare
rohanKanojia
approved these changes
May 31, 2018
|
[merge] |
|
Thanks @piyush1594 for merging. Do you plan to cut a new release soon? |
|
@piyush1594 I'm sorry to nag you but would it be possible to run a release of the current master (including this PR)? |
|
Yaa sure, will do a release in a day or two |
Merged
piyush-garg
added a commit
to piyush-garg/kubernetes-client
that referenced
this pull request
Jun 12, 2018
If we keep that test, it will return different URl for every other CI. If we do some changes in test, it will be similar to other tests like setting masterUrl and all. This started happening after PR fabric8io#1086 Asserting not null and is URL is the only solution but does not make any difference as we have another tests for this func.
|
Hey @Vlatombe Kubernetes Client 3.2.0 released which have this. |
|
@piyush1594 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can differ from
kubernetes.default.svcin some occasions.Uses the same logic as the go client (https://github.com/kubernetes/client-go/blob/master/rest/config.go#L313-L336)