-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove bouncycastle dependency for EC key support #6008
Comments
@coopstah13 do you have suggested changes for this? The test case that was added for bcfips does not work with just the jdk - it fails with "java.security.spec.InvalidKeySpecException: java.security.InvalidKeyException: IOException : version mismatch: (supported: 00, parsed: 01 ..." |
We probable need to add a specific case for The idea would be to add some sort of fallback mechanism in Line 198 in 2f11261
so that we attempt to use the JDK-provided classes and then use BouncyCastle if the JVM doesn't provide them. |
Yes, I understand what could be done for eliptical curve keys, but nothing simple worked. Taking another look the best I could come up with was to borrow some code from vertx. I'll open a pr with that. |
closes: fabric8io#6008 Signed-off-by: Steve Hawkins <[email protected]>
closes: fabric8io#6008 Signed-off-by: Steve Hawkins <[email protected]>
closes: fabric8io#6008 Signed-off-by: Steve Hawkins <[email protected]>
closes: fabric8io#6008 Signed-off-by: Steve Hawkins <[email protected]>
closes: fabric8io#6008 Signed-off-by: Steve Hawkins <[email protected]>
closes: fabric8io#6008 Signed-off-by: Steve Hawkins <[email protected]>
closes: fabric8io#6008 Signed-off-by: Steve Hawkins <[email protected]>
I've had the same issue and was to remove the Bouncycastle library after upgrading the fabric8 client from 6.13.1 to 7.0-SNAPSHOT (built locally). |
End of September or October if everything goes well. |
Hello @manusa , just out of curiosity, is the release for 7.0.0 on track? Thank you |
Hi @martinwunderlich-celonis |
Is your task related to a problem? Please describe
Newer version of BouncyCastle doesn't work with BCFIPS provider
Describe the solution you'd like
Remove dependency on BouncyCastle and rely on JDK only. The dependency is only used for EC keys, but they are supported since at least JDK8.
Describe alternatives you've considered
I have pinned the transitive bouncycastle dependency to an older version (1.68) in our repository as it seems to be the last one that doesn't have the problem.
Additional context
No response
The text was updated successfully, but these errors were encountered: