Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NULL pass phrase SHOULD NOT be replaced with "changeit" #5126

Closed
AKGarimella opened this issue May 12, 2023 · 0 comments · Fixed by #5131
Closed

NULL pass phrase SHOULD NOT be replaced with "changeit" #5126

AKGarimella opened this issue May 12, 2023 · 0 comments · Fixed by #5131
Assignees
@shawkins
Labels
enhancement
Milestone
6.7.0

Comments

@AKGarimella
Copy link

https://github.com/fabric8io/kubernetes-client/blob/8cf4804a039bc221aed2f6bae3d4c2568874fb5f/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/internal/CertUtils.java#LL83C1-L83C1

TrustStores can have null pass phrase. We are unable to use fabric8io client with our custom truststore which has no pass phrase (PEM format) because the code by default uses changeit when pass phrase is null. This shouldn't be the case.

trustStore.load(in, null); is OK with java KeyStore/TrustStore.

null string => null char[]
Also, production systems typically do not changeit as their default pass phrase. So such an assumption in code should never be made.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 15, 2023
@shawkins
fix fabric8io#5126: fallback to changeit only if null/empty does not …
fbcd744 
…work
@shawkins shawkins mentioned this issue May 15, 2023
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 15, 2023
@shawkins
fix fabric8io#5126: fallback to changeit only if null/empty does not …
1b7d646 
…work
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 15, 2023
@shawkins
fix fabric8io#5126: fallback to changeit only if null/empty does not …
c343d3a 
…work
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 15, 2023
@shawkins
fix fabric8io#5126: fallback to changeit only if null/empty does not …
6cc5d9a 
…work
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue May 25, 2023
@shawkins @manusa
fix fabric8io#5126: fallback to changeit only if null/empty does not …
48d579c 
…work
@manusa manusa added this to the 6.7.0 milestone May 25, 2023
manusa pushed a commit that referenced this issue May 25, 2023
@shawkins @manusa
fix #5126: fallback to changeit only if null/empty does not work
df40714
@AKGarimella AKGarimella mentioned this issue Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
enhancement
Projects
None yet
Milestone
6.7.0
Development

Successfully merging a pull request may close this issue.

fix #5126: fallback to changeit only if null/empty does not work shawkins/kubernetes-client
3 participants
@manusa @shawkins @AKGarimella