Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage Serialization yaml mapper #4998

Closed
shawkins opened this issue Mar 25, 2023 · 3 comments · Fixed by #4999
Closed

Remove the usage Serialization yaml mapper #4998

shawkins opened this issue Mar 25, 2023 · 3 comments · Fixed by #4999
Assignees
Milestone

Comments

@shawkins
Copy link
Contributor

The yaml mapper is mostly not needed and can be avoided entirely with logic similar to what is done for parsing. This will also remove the need for the method to clear the mapper.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 25, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 25, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 26, 2023
@manusa manusa added this to the 6.6.0 milestone Mar 27, 2023
@andreaTP
Copy link
Member

The yaml mapper is used under the scenes by the java generator as most of the provided CRDs are in yaml format.

What would be a viable substitution for it?

@shawkins
Copy link
Contributor Author

shawkins commented Mar 27, 2023

@andreaTP the unmarshal methods and asYaml will handle deserialization and serialization. Do you have a scenario that requires direct access to the mapper?

@andreaTP
Copy link
Member

In the java-generator we are only using the high level: Serialization.unmarshal, so I should be good 👍

manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants