Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need for KubernetesResourceMappingProvider #3923

Closed
shawkins opened this issue Mar 3, 2022 · 2 comments · Fixed by #4511
Closed

Remove the need for KubernetesResourceMappingProvider #3923

shawkins opened this issue Mar 3, 2022 · 2 comments · Fixed by #4511
Assignees
@shawkins
Labels
status/never-stale
Milestone
6.3.0

Comments

@shawkins
Copy link
Contributor

shawkins commented Mar 3, 2022

I think we can also do away with the need for KubernetesResourceMappingProvider - basically the same mechanism as what is registering handlers that is proposed by #3845 but via the ExtensionAdapter. All it needs to do is declare the packages of the models.

It all depends on the expectation of if the user can make use of KubernetesDesializer / Serialization independently of the client as that will complicate this simplification.

Originally posted by @shawkins in #3876 (comment)
@shawkins shawkins added this to the 6.x milestone Mar 11, 2022
@shawkins shawkins mentioned this issue Mar 14, 2022
Merged
11 tasks
@shawkins
Copy link
Contributor Author

Relates to #3993

@shawkins shawkins mentioned this issue Mar 30, 2022
Closed
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 27, 2022
@shawkins
fix fabric8io#3923: minimizing the need for a mapping provider by usi…
5a6f839 
…ng jandex
@stale
Copy link

stale bot commented Jun 26, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Jun 26, 2022
@stale stale bot closed this as completed Jul 4, 2022
@manusa manusa reopened this Sep 1, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 19, 2022
@shawkins
fix fabric8io#3923: minimizing the need for a mapping provider by usi…
e1e4725 
…ng jandex
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 19, 2022
@shawkins
fix fabric8io#3923: removing the need for mappingproviders
e65e5a7
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 19, 2022
@shawkins
fix fabric8io#3923: fully regenerating the models
277be8c
@shawkins shawkins mentioned this issue Oct 19, 2022
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 19, 2022
@shawkins
cleaning up leftovers from the jandex branch
f8e60a2 
fix fabric8io#3923
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 19, 2022
@shawkins
fix fabric8io#3923: removing the need for mappingproviders
a9a55b1
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 19, 2022
@shawkins
fix fabric8io#3923: fully regenerating the models
7903a9a
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 19, 2022
@shawkins
fix fabric8io#3923: cleaning up leftovers and adding osgi handling
84ffd1e
@shawkins shawkins modified the milestones: 6.x, 6.3.0 Oct 20, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 14, 2022
@shawkins
fix fabric8io#3923: removing the need for mappingproviders
a1fa96a
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 14, 2022
@shawkins
fix fabric8io#3923: fully regenerating the models
702ca7b
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 14, 2022
@shawkins
fix fabric8io#3923: cleaning up leftovers and adding osgi handling
470d852
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 14, 2022
@shawkins
fix fabric8io#3923: removing kind only from registered classes
4eda49b
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 16, 2022
@shawkins
fix fabric8io#3923: adding a changelog KubernetesResourceMappingProvi…
61c9a98 
…der removal
manusa pushed a commit that referenced this issue Nov 21, 2022
@shawkins @manusa
fix #3923: removing the need for mappingproviders
7806ed4
manusa pushed a commit that referenced this issue Nov 21, 2022
@shawkins @manusa
fix #3923: fully regenerating the models
9210491
manusa pushed a commit that referenced this issue Nov 21, 2022
@shawkins @manusa
fix #3923: cleaning up leftovers and adding osgi handling
7b2426b
manusa pushed a commit that referenced this issue Nov 21, 2022
@shawkins @manusa
fix #3923: removing kind only from registered classes
97f53c7
manusa pushed a commit that referenced this issue Nov 21, 2022
@shawkins @manusa
fix #3923: adding a changelog KubernetesResourceMappingProvider removal
e86646a
manusa added a commit to manusa/quarkus that referenced this issue Dec 20, 2022
@manusa
fix: replace ServiceBinding with GenericKubernetesResource
5b41418 
Since Fabric8 Kubernetes Client 6.3, types are no longer
automatically registered for deserialization.
For automatic type registration an
`META-INF/services/io.fabric8.kubernetes.api.model.KubernetesResource`
SPI definition file needs to be provided instead with the
Kubernetes Resources (Objects -HasMadata impls-) that need to be
automatically registered in the KubernetesDeserializer.

fabric8io/kubernetes-client#3923
Signed-off-by: Marc Nuri <[email protected]>
@manusa manusa mentioned this issue Dec 20, 2022
Merged
ebullient pushed a commit to maxandersen/quarkus that referenced this issue Jan 24, 2023
@manusa @ebullient
fix: replace ServiceBinding with GenericKubernetesResource
5ab2388 
Since Fabric8 Kubernetes Client 6.3, types are no longer
automatically registered for deserialization.
For automatic type registration an
`META-INF/services/io.fabric8.kubernetes.api.model.KubernetesResource`
SPI definition file needs to be provided instead with the
Kubernetes Resources (Objects -HasMadata impls-) that need to be
automatically registered in the KubernetesDeserializer.

fabric8io/kubernetes-client#3923
Signed-off-by: Marc Nuri <[email protected]>
@BramMeerten BramMeerten mentioned this issue Mar 27, 2023
Closed
@shawkins shawkins mentioned this issue Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
status/never-stale
Projects
None yet
Milestone
6.3.0
Development

Successfully merging a pull request may close this issue.

KubernetesDeserializer class resolving with SPI shawkins/kubernetes-client
2 participants
@manusa @shawkins