Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeMetrics is currently marked as Namespaced should be cluster scoped #3662

Closed
manusa opened this issue Dec 17, 2021 · 0 comments · Fixed by #3688
Closed

NodeMetrics is currently marked as Namespaced should be cluster scoped #3662

manusa opened this issue Dec 17, 2021 · 0 comments · Fixed by #3688
Assignees
@rohanKanojia
Labels
bug
Milestone
5.11.1

Comments

@manusa
Copy link
Member

manusa commented Dec 17, 2021

Also related to this is that NodeMetrics is currently marked as Namespaced, and it should not be.

Originally posted by @shawkins in #3639 (comment)
@manusa manusa added the bug label Dec 17, 2021
@shawkins shawkins mentioned this issue Dec 17, 2021
Merged
11 tasks
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 23, 2021
@rohanKanojia
Fix fabric8io#3662: NodeMetrics should be marked as Cluster Scoped re…
8e33919 
…source

NodeMetrics should not implement Namespaced interface

Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 23, 2021
@rohanKanojia
Fix fabric8io#3662: NodeMetrics should be marked as Cluster Scoped re…
fb4abe1 
…source

NodeMetrics should not implement Namespaced interface

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia mentioned this issue Dec 23, 2021
Merged
11 tasks
@manusa manusa added this to the 5.11.1 milestone Dec 23, 2021
Repository owner moved this from Review to Done in Eclipse JKube - Sprint #211 + Sprint #212 (2021-12-01 → 2022-01-11) Dec 24, 2021
manusa pushed a commit that referenced this issue Dec 24, 2021
@rohanKanojia @manusa
Fix #3662: NodeMetrics should be marked as Cluster Scoped resource
b5af2df 
NodeMetrics should not implement Namespaced interface

Signed-off-by: Rohan Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
bug
Projects
None yet
Milestone
5.11.1
Development

Successfully merging a pull request may close this issue.

Fix #3662: NodeMetrics should be marked as Cluster Scoped resource rohanKanojia/kubernetes-client
2 participants
@manusa @rohanKanojia