Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Informer.hasSynced and Store.isPopulated #3090

Closed
shawkins opened this issue May 7, 2021 · 0 comments
Closed

Informer.hasSynced and Store.isPopulated #3090

shawkins opened this issue May 7, 2021 · 0 comments
Assignees
@shawkins
Milestone
5.5.0

Comments

@shawkins
Copy link
Contributor

shawkins commented May 7, 2021

A change in #1961 was to set hasSynced to false when re-listing. This differs from the go client behavior - where once true, it won't flip back to false see https://github.com/kubernetes/client-go/blob/f6ce18ae578c8cca64d14ab9687824d9e1305a67/tools/cache/delta_fifo.go and the doc https://github.com/kubernetes/client-go/blob/f6ce18ae578c8cca64d14ab9687824d9e1305a67/tools/cache/shared_informer.go#L160

Can we return hasSynced to the original meaning and introduce more specific methods for additional checks - such as isWatching?

A change along these lines would allow us to eliminate the Store.isPopulated method

cc @rohanKanojia
This was referenced May 8, 2021
Closed
Closed
@shawkins shawkins mentioned this issue May 18, 2021
Closed
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 24, 2021
@shawkins
fix fabric8io#3090 fabric8io#3091 refining the store interface and ha…
975c377 
…sSynced

splitting internal and mutative methods to SyncableStore

removing isPopulated and directly wiring the cache to be used
this adds an isRunning method to the SharedInformer.  this clarifies the
cache methods to be more like a map and the underlying map is now
concurrent to remove read locks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 25, 2021
@shawkins
fix fabric8io#3090 fabric8io#3091 refining the store interface and ha…
65e3e5f 
…sSynced

splitting internal and mutative methods to SyncableStore

removing isPopulated and directly wiring the cache to be used
this adds an isRunning method to the SharedInformer.  this clarifies the
cache methods to be more like a map and the underlying map is now
concurrent to remove read locks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 25, 2021
@shawkins
fix fabric8io#3090 fabric8io#3091 refining the store interface and ha…
57ba9f6 
…sSynced

splitting internal and mutative methods to SyncableStore

removing isPopulated and directly wiring the cache to be used
this adds an isRunning method to the SharedInformer.  this clarifies the
cache methods to be more like a map and the underlying map is now
concurrent to remove read locks
@shawkins shawkins self-assigned this May 25, 2021
@manusa manusa closed this as completed in 47310d7 Jun 9, 2021
@manusa manusa added this to the 5.5.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
5.5.0
Development

No branches or pull requests
2 participants
@manusa @shawkins