-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RawCustomResourceOperationsImpl#delete should return a boolean value indicating deletion status #2781
Closed
rohanKanojia opened this issue
Feb 3, 2021
· 0 comments
· Fixed by #2820 or jenkinsci/kubernetes-client-api-plugin#83
Closed
RawCustomResourceOperationsImpl#delete should return a boolean value indicating deletion status #2781
rohanKanojia opened this issue
Feb 3, 2021
· 0 comments
· Fixed by #2820 or jenkinsci/kubernetes-client-api-plugin#83
Comments
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Feb 19, 2021
…urn a boolean value Align RawCustomResource delete API to return a boolean value indicating status for deletion just like we have in regular DSL. Right now we're just throwing an exception in case item doesn't exist in server.
11 tasks
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Feb 22, 2021
…urn a boolean value Align RawCustomResource delete API to return a boolean value indicating status for deletion just like we have in regular DSL. Right now we're just throwing an exception in case item doesn't exist in server.
manusa
pushed a commit
that referenced
this issue
Mar 1, 2021
…lean value Align RawCustomResource delete API to return a boolean value indicating status for deletion just like we have in regular DSL. Right now we're just throwing an exception in case item doesn't exist in server.
This was referenced Mar 12, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we have these delete methods in API which seems to work okay but they fail with 404 in case resource is not present in the cluster:
kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/RawCustomResourceOperationsImpl.java
Lines 427 to 459 in 3e5cb2f
We discovered this behavior in one of the issues[0] on Eclipse JKube. I think we should align this behavior with standard deletion API's to return
false
if resource requested for deletion doesn't exist in server:kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/base/BaseOperation.java
Lines 699 to 703 in 3e5cb2f
[0] eclipse-jkube/jkube#534
The text was updated successfully, but these errors were encountered: