PodExecOptions (as object of AdmissionReview#request) not supported?

[duco-lw]

When reading JSON representing an AdmissionReview for a pod/exec request (PodExecOptions), no resource type is found.

With this code (which can be cut down to a simple test if needed):

...
// imports included for completeness
import javax.inject.Inject;
import javax.ws.rs.Consumes;
import javax.ws.rs.POST;
import javax.ws.rs.Path;
import javax.ws.rs.Produces;
import javax.ws.rs.core.MediaType;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import io.fabric8.kubernetes.api.model.admission.AdmissionRequest;
import io.fabric8.kubernetes.api.model.admission.AdmissionResponseBuilder;
import io.fabric8.kubernetes.api.model.admission.AdmissionReview;
...
	@POST
	public AdmissionReview validate(String admissionReviewJSON) {
		ObjectMapper objectMapper = new ObjectMapper();
		final AdmissionReview admissionReview;
		try {
			// have to use this approach as passing parameter of type AdmissionReview doesn't work
			admissionReview = objectMapper.readValue(admissionReviewJSON, AdmissionReview.class);
		} catch (JsonProcessingException e) {
			logger.error("Failed to parse AdmissionReview", e);
			return null;
		}

		admissionReview.setResponse(new AdmissionResponseBuilder()
				.withUid(admissionRequest.getUid())
				.withAllowed(true) // TODO: check
				.build());
		return admissionReview;
	}

The JSON passed in is:

{
   "kind":"AdmissionReview",
   "apiVersion":"admission.k8s.io/v1",
   "request":{
      "uid":"b7a46c3d-a6c8-4f57-b616-27d839f4e210",
      "kind":{
         "group":"",
         "version":"v1",
         "kind":"PodExecOptions"
      },
      "resource":{
         "group":"",
         "version":"v1",
         "resource":"pods"
      },
      "subResource":"exec",
      "requestKind":{
         "group":"",
         "version":"v1",
         "kind":"PodExecOptions"
      },
      "requestResource":{
         "group":"",
         "version":"v1",
         "resource":"pods"
      },
      "requestSubResource":"exec",
      "name":"dummy-599f7fdbdc-22gmf",
      "namespace":"test123",
      "operation":"CONNECT",
      "userInfo":{
         "username":"admin",
         "uid":"admin",
         "groups":[
            "system:masters",
            "system:authenticated"
         ]
      },
      "object":{
         "kind":"PodExecOptions",
         "apiVersion":"v1",
         "stdin":true,
         "stdout":true,
         "tty":true,
         "container":"dummy",
         "command":[
            "sh",
            "-c",
            "command -v bash \u003e/dev/null \u0026\u0026 exec bash || exec sh"
         ]
      },
      "oldObject":null,
      "dryRun":false,
      "options":null
   }
}

I get the following error:
Failed to parse AdmissionReview: com.fasterxml.jackson.databind.JsonMappingException: No resource type found for:v1#PodExecOptions

What is the expected approach here?
Is it simply that the model is missing and might ship with a new release in future?
Or am I missing something? (If so, what?)

[rohanKanojia]

ah, looks like Fabric8 Kubernetes Model doesn't contain PodExecOptions object. We should add it.

[rohanKanojia]

@duco-lw: Would it be possible for you to submit a Pull Request for this one? Implementing it should not be that hard. Just need to add an entry here:

kubernetes-client/kubernetes-model-generator/kubernetes-model-core/cmd/generate/generate.go

Lines 48 to 63 in ee93164

	ListOptions metav1.ListOptions
	DeleteOptions metav1.DeleteOptions
	CreateOptions metav1.CreateOptions
	UpdateOptions metav1.UpdateOptions
	GetOptions metav1.GetOptions
	PatchOptions metav1.PatchOptions
	Time metav1.Time
	MicroTime metav1.MicroTime
	RootPaths metav1.RootPaths
	GroupVersionKind metav1.GroupVersionKind
	GroupVersionResource metav1.GroupVersionResource
	Quantity resource.Quantity
	PodList kapi.PodList
	PodTemplateList kapi.PodTemplateList
	ReplicationControllerList kapi.ReplicationControllerList

I think PodExecOptions is in core/v1 . So you would just need to add one additional kapi.PodExecOptions there. Then you can simply issue make on top of kubernetes-model-generator/kubernetes-model-core which would modify schema.

[duco-lw]

PR #2335