Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshift-model has unresolvable osgi-import #2309

Closed
joshiste opened this issue Jun 24, 2020 · 3 comments · Fixed by #2310
Closed

openshift-model has unresolvable osgi-import #2309

joshiste opened this issue Jun 24, 2020 · 3 comments · Fixed by #2310
Labels
bug platform/openshift Specific to OpenShift

Comments

@joshiste
Copy link
Contributor

the io.fabric8:openshift-model:4.10.2 imports package io.fabric8.kubernetes.internal in its MANIFEST.MF but this package is private to kubernetes-model-core.

Having a quick look on the sources the culprit seems to this import:

kubernetes-client/kubernetes-model-generator/openshift-model/src/main/java/io/fabric8/openshift/api/model/Template.java

Line 30 in 2ed5866

import io.fabric8.kubernetes.internal.HasMetadataComparator;

@rohanKanojia
Copy link
Member

@joshiste : Thanks a lot for your bug report. Would you like to contribute a PR to fix this issue?

@rohanKanojia rohanKanojia added bug platform/openshift Specific to OpenShift labels Jun 24, 2020
@joshiste
Copy link
Contributor Author

joshiste commented Jun 24, 2020 •
edited
Loading

... my proposed fix would be to move the HasMetadataComparator into a public package. k?

@rohanKanojia
Copy link
Member

I'm okay with moving it to public package as long as it doesn't break anything ;-)

joshiste added a commit to joshiste/kubernetes-client that referenced this issue Jun 24, 2020
@joshiste
move HasMetadataComparator to exported package
fdf2c53 
The openshift-model needs to make use of the HasMetadataComparator and therefore
it should reside in an exported package

fixes fabric8io#2309
@joshiste joshiste mentioned this issue Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug platform/openshift Specific to OpenShift
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move HasMetadataComparator to exported package joshiste/kubernetes-client
2 participants
@joshiste @rohanKanojia