Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple openshift-model dependency from kubernetes-client #2141

Closed
manusa opened this issue Apr 17, 2020 · 2 comments · Fixed by #2443
Closed

Decouple openshift-model dependency from kubernetes-client #2141

manusa opened this issue Apr 17, 2020 · 2 comments · Fixed by #2443
Assignees
@rohanKanojia
Labels
status/never-stale

Comments

@manusa
Copy link
Member

manusa commented Apr 17, 2020 •
edited
Loading

Description

After model split (#2108 #2137) we have to keep a dependency to openshift-model in kubernetes-client as some of the classes still import OpenShift specific model types (io.fabric8.openshift.api.model.* e.g. ClusterOperationsImpl)

Classes with such imports should segregated with resulting classes moved to openshift-client module.

Blocked by
@rohanKanojia
Copy link
Member

Actually earlier entire model was inside kubernetes-model jar. We didn't have much choice earlier, but I think after decoupling we can achieve this.

@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Jul 18, 2020
@stale stale bot closed this as completed Jul 25, 2020
@rohanKanojia rohanKanojia reopened this Jul 25, 2020
@stale stale bot removed the status/stale label Jul 25, 2020
@stale stale bot closed this as completed Aug 1, 2020
@rohanKanojia rohanKanojia reopened this Aug 1, 2020
@rohanKanojia rohanKanojia self-assigned this Aug 26, 2020
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Aug 26, 2020
@rohanKanojia
Fix fabric8io#2141: Decouple OpenShift Model dependency from Kubernet…
3350ab1 
…es Client
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Aug 27, 2020
@rohanKanojia
Fix fabric8io#2141: Decouple OpenShift Model dependency from Kubernet…
99424a6 
…es Client
@rohanKanojia rohanKanojia mentioned this issue Aug 27, 2020
Merged
11 tasks
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Aug 27, 2020
@rohanKanojia
Fix fabric8io#2141: Decouple OpenShift Model dependency from Kubernet…
75ca9b0 
…es Client
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Sep 2, 2020
@rohanKanojia
Fix fabric8io#2141: Decouple OpenShift Model dependency from Kubernet…
183aebd 
…es Client
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Sep 16, 2020
@rohanKanojia
Fix fabric8io#2141: Decouple OpenShift Model dependency from Kubernet…
c9f743e 
…es Client
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Sep 16, 2020
@rohanKanojia
Fix fabric8io#2141: Decouple OpenShift Model dependency from Kubernet…
cc8a81d 
…es Client
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Sep 17, 2020
@rohanKanojia
Fix fabric8io#2141: Decouple OpenShift Model dependency from Kubernet…
c65b454 
…es Client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
status/never-stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2141: Decouple OpenShift Model dependency from Kubernetes Client rohanKanojia/kubernetes-client
2 participants
@manusa @rohanKanojia