Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WatchConnectionManager does not respect user specified pingInterval #1767

Closed
igorcalabria opened this issue Sep 16, 2019 · 2 comments · Fixed by #1768
Closed

WatchConnectionManager does not respect user specified pingInterval #1767

igorcalabria opened this issue Sep 16, 2019 · 2 comments · Fixed by #1768

Comments

@igorcalabria
Copy link
Contributor

Hi everyone, is there a reason why https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/WatchConnectionManager.java#L85 overrides user's specified pingInterval with a fixed value of 30 seconds? Is this a specific requirement of kubernetes? If that's not the case I could provide a PR that reverts this
@rohanKanojia
Copy link
Member

@igorcalabria : oops, I did it in order to deal with ping not received within x seconds. Yeah, it would be great if you could raise a PR to override this default value. But if value is not specified, pingInterval should be kept to 30 seconds only.

igorcalabria added a commit to igorcalabria/kubernetes-client that referenced this issue Sep 16, 2019
@igorcalabria
fix (fabric8io#1767): remove fixed override for ping interval in okHt…
ed9a7ce 
…tpClient

since this value is configurable we should not override it with a fixed value
igorcalabria added a commit to igorcalabria/kubernetes-client that referenced this issue Sep 16, 2019
@igorcalabria
fix (fabric8io#1767): change DEFAULT_WEBSOCKET_PING_INTERVAL to 3 sec…
a73a521 
…onds

requested in fabric8io#1767
igorcalabria added a commit to igorcalabria/kubernetes-client that referenced this issue Sep 16, 2019
@igorcalabria
fix (fabric8io#1767): change default ping interval to 3 seconds
ee0a8a0
igorcalabria added a commit to igorcalabria/kubernetes-client that referenced this issue Sep 16, 2019
@igorcalabria
fix (fabric8io#1767): set default ping interval to 30 seconds
2b17994
@igorcalabria igorcalabria mentioned this issue Sep 16, 2019
Merged
@igorcalabria
Copy link
Contributor Author

@rohanKanojia I have provided the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iss 1767 igorcalabria/kubernetes-client
2 participants
@igorcalabria @rohanKanojia