finishing off review changes and adding a test

fabric8io · Apr 29, 2024 · ef05f18 · ef05f18
1 parent 4352572
commit ef05f18
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/crd-generator/api-v2/src/main/java/io/fabric8/crdv2/generator/AbstractJsonSchema.java b/crd-generator/api-v2/src/main/java/io/fabric8/crdv2/generator/AbstractJsonSchema.java
@@ -397,7 +397,7 @@ private T resolveProperty(LinkedHashMap<String, String> visited, InternalSchemaS
       // currently on string enums are supported
       StringSchema stringSchema = jacksonSchema.asStringSchema();
       if (!stringSchema.getEnums().isEmpty()) {
-        Set<String> ignores = type.isEnumType() ? findIngoredEnumConstants(type) : Collections.emptySet();
+        Set<String> ignores = type.isEnumType() ? findIgnoredEnumConstants(type) : Collections.emptySet();
         final JsonNode[] enumValues = stringSchema.getEnums().stream()
             .sorted()
             .filter(s -> !ignores.contains(s))

diff --git a/crd-generator/api-v2/src/test/java/io/fabric8/crdv2/example/complex/ComplexStatus.java b/crd-generator/api-v2/src/test/java/io/fabric8/crdv2/example/complex/ComplexStatus.java
@@ -40,7 +40,7 @@ public ComplexStatus() {
   private State state;
 
   @JsonProperty("message")
-  @PrinterColumn(name = "Message")
+  @PrinterColumn()
   private String message;
 
   public State getState() {

diff --git a/crd-generator/api-v2/src/test/resources/complexkinds.example.com-v1.yml b/crd-generator/api-v2/src/test/resources/complexkinds.example.com-v1.yml
@@ -29,7 +29,7 @@ spec:
   versions:
   - additionalPrinterColumns:
     - jsonPath: .status.message
-      name: Message
+      name: MESSAGE
       priority: 0
       type: string
     - jsonPath: .status.state