chore : fix ambigous references to assertThatThrownBy

Signed-off-by: Rohan Kumar <[email protected]>
fabric8io · Jan 2, 2024 · de8e718 · de8e718
1 parent 73ccfd4
commit de8e718
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/...java/io/fabric8/kubernetes/client/server/mock/crud/KubernetesCrudDispatcherPatchTest.java b/...java/io/fabric8/kubernetes/client/server/mock/crud/KubernetesCrudDispatcherPatchTest.java
@@ -36,6 +36,7 @@
 import java.util.function.UnaryOperator;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
@@ -319,11 +320,10 @@ void differentResourceVersionConflictEdit() {
           .addToData("key", "changed")
           .build());
       // Then
-      assertThatThrownBy(patchedCmOp::patch)
-          .asInstanceOf(InstanceOfAssertFactories.type(KubernetesClientException.class))
+      assertThatExceptionOfType(KubernetesClientException.class)
+          .isThrownBy(patchedCmOp::patch)
           .hasFieldOrPropertyWithValue("code", 409)
-          .extracting(KubernetesClientException::getMessage).asString()
-          .contains("the object has been modified;");
+          .withMessageContaining("the object has been modified;");
     }
 
     @Test

diff --git a/...es-client-api/src/test/java/io/fabric8/kubernetes/client/http/StandardHttpClientTest.java b/...es-client-api/src/test/java/io/fabric8/kubernetes/client/http/StandardHttpClientTest.java
@@ -41,6 +41,7 @@
 import java.util.stream.Stream;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -231,8 +232,9 @@ void testRequestTimeout() {
         });
 
     Awaitility.await().atMost(10, TimeUnit.SECONDS).until(consumeFuture::isDone);
-    assertThatThrownBy(consumeFuture::get)
-        .isInstanceOf(ExecutionException.class).hasCauseInstanceOf(TimeoutException.class);
+    assertThatExceptionOfType(ExecutionException.class)
+        .isThrownBy(consumeFuture::get)
+        .withCauseExactlyInstanceOf(TimeoutException.class);
   }
 
   @Test