try to fix e2e tests

fabric8io · Dec 15, 2021 · 5f7c3ac · 5f7c3ac
1 parent ef59c48
commit 5f7c3ac
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/crd-generator/api/src/main/java/io/fabric8/crd/generator/AbstractJsonSchema.java b/crd-generator/api/src/main/java/io/fabric8/crd/generator/AbstractJsonSchema.java
@@ -116,7 +116,6 @@ protected T internalFrom(TypeDef definition, String... ignore) {
   }
 
   private T internalFromImpl(TypeDef definition, Set<String> visited, String... ignore) {
-    visited.add(definition.getFullyQualifiedName());
     final B builder = newBuilder();
     Set<String> ignores =
       ignore.length > 0 ? new LinkedHashSet<>(Arrays.asList(ignore)) : Collections
@@ -420,6 +419,7 @@ private T internalFromImpl(String name, TypeRef typeRef, Set<String> visited) {
             if (!def.getFullyQualifiedName().startsWith("java") && visited.contains(def.getFullyQualifiedName())) {
               throw new IllegalArgumentException("Found a cyclic reference involving " + def.getFullyQualifiedName());
             }
+            visited.add(def.getFullyQualifiedName());
             return internalFromImpl(def, visited);
           }