Move afterConnectionFailure callback to retryWithExponentialBackoff…

… so its invoked when an established websocket connection fails
fabric8io · Jul 22, 2024 · 0b17eda · 0b17eda
1 parent 39e6e12
commit 0b17eda
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/...rnetes-client-api/src/main/java/io/fabric8/kubernetes/client/http/StandardHttpClient.java b/...rnetes-client-api/src/main/java/io/fabric8/kubernetes/client/http/StandardHttpClient.java
@@ -108,13 +108,6 @@ private CompletableFuture<HttpResponse<AsyncBody>> consumeBytesOnce(StandardHttp
     final Consumer<List<ByteBuffer>> effectiveConsumer = consumer;
 
     CompletableFuture<HttpResponse<AsyncBody>> cf = consumeBytesDirect(effectiveRequest, effectiveConsumer);
-    cf.exceptionally(throwable -> {
-      builder.interceptors.forEach((s, interceptor) -> interceptor.afterConnectionFailure(effectiveRequest, throwable));
-      if (throwable instanceof CompletionException) {
-        throw (CompletionException) throwable;
-      }
-      throw new CompletionException(throwable);
-    });
     cf.thenAccept(
         response -> builder.getInterceptors().values().forEach(i -> i.after(effectiveRequest, response, effectiveConsumer)));
 
@@ -184,15 +177,19 @@ private <V> CompletableFuture<V> retryWithExponentialBackoff(
               }
             }
           } else {
+            final Throwable finalThrowable;
             if (throwable instanceof CompletionException) {
-              throwable = throwable.getCause();
+              finalThrowable = throwable.getCause();
+            } else {
+              finalThrowable = throwable;
             }
-            if (throwable instanceof IOException) {
+            builder.interceptors.forEach((s, interceptor) -> interceptor.afterConnectionFailure(request, finalThrowable));
+            if (finalThrowable instanceof IOException) {
               // TODO: may not be specific enough - incorrect ssl settings for example will get caught here
               LOG.debug(
                   String.format("HTTP operation on url: %s should be retried after %d millis because of IOException",
                       uri, retryInterval),
-                  throwable);
+                  finalThrowable);
               return true;
             }
           }