Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for dockerd Builder-Version header #1794

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rroesch1
Copy link

  • in docker 23 dockerd introduced the 'Builder-Version' header to expose the recommended version of the builder backend
  • it is up to the client to follow this recommendation
  • dockerd uses the deprecated 'classic builder' if clients do not set the 'version' build option explicitly
  • d-m-p should always set the 'version' option as recommended by the dockerd

Refs: #1711

@rroesch1 rroesch1 force-pushed the use-recommended-build-backend branch from 9893294 to 70d4d15 Compare June 19, 2024 14:04
* in docker 23 dockerd introduced the 'Builder-Version' header
  to expose the recommended version of the builder backend
* it is up to the client to follow this recommendation
* dockerd uses the deprecated 'classic builder' if clients
  do not set the 'version' build option explicitly
* d-m-p should always set the 'version' option as recommended
  by the dockerd

Refs: fabric8io#1711
@rroesch1 rroesch1 force-pushed the use-recommended-build-backend branch from 70d4d15 to 00af9b7 Compare June 19, 2024 14:22
Copy link

sonarcloud bot commented Jun 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
40.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@rroesch1 rroesch1 marked this pull request as ready for review June 19, 2024 15:38
@rroesch1 rroesch1 marked this pull request as draft June 20, 2024 09:07
@rohanKanojia
Copy link
Member

@rroesch1 : Some integration tests seem to be failing. Could you please take a look at these failures?

@rroesch1
Copy link
Author

@rroesch1 : Some integration tests seem to be failing. Could you please take a look at these failures?

Well, i got that but it took me while to realize what's going wrong here:

  • I am sorry to say it isn't that easy to get buildkit support …
  • enabling buildkit actually works, but builds may fail in some cases
  • The reason for this is, that buildkit expects to have some sort of "callback api" to the client. To provide this callback, the client has to initiate a gRPC session (see: Initialize interactive session API) + the client has to implement several gRPC services.
  • I couldn't find any documentation about these services, but the code for these seem to here here
  • Creating (and maintaining) a Java implementation for these gRPC services is probably a monstrous task. I am afraid to say that it's probably easier to stop using the Docker Engine API at all and use the CLI (docker build(x)) instead. At least for now i have no clue how to deal with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants