Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pullRetries and pushRetries fields #1697

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rohanKanojia
Copy link
Member

originally created by @bkelley17 in #994

Currently the plugin allows configurable retries for push, but not for pull. This change allows retries to be configured for pull as well.

Signed-off-by: Ben Kelley [email protected]

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1697 (df88d44) into master (bb612ed) will increase coverage by 0.05%.
The diff coverage is 80.95%.

❗ Current head df88d44 differs from pull request most recent head 9b6f689. Consider uploading reports for the commit 9b6f689 to get more accurate results

@@             Coverage Diff              @@
##             master    #1697      +/-   ##
============================================
+ Coverage     64.29%   64.35%   +0.05%     
- Complexity     2223     2229       +6     
============================================
  Files           172      172              
  Lines         10053    10058       +5     
  Branches       1381     1381              
============================================
+ Hits           6464     6473       +9     
+ Misses         3051     3047       -4     
  Partials        538      538              
Files Changed Coverage Δ
...c/main/java/io/fabric8/maven/docker/WatchMojo.java 0.00% <0.00%> (ø)
.../fabric8/maven/docker/service/RegistryService.java 80.72% <ø> (ø)
.../io/fabric8/maven/docker/service/WatchService.java 16.80% <0.00%> (ø)
...rc/main/java/io/fabric8/maven/docker/PushMojo.java 53.84% <50.00%> (ø)
...va/io/fabric8/maven/docker/AbstractDockerMojo.java 36.90% <100.00%> (+2.33%) ⬆️
...c/main/java/io/fabric8/maven/docker/BuildMojo.java 51.20% <100.00%> (ø)
...ven/docker/access/hc/DockerAccessWithHcClient.java 30.92% <100.00%> (+0.07%) ⬆️
.../io/fabric8/maven/docker/service/BuildService.java 63.95% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rohanKanojia rohanKanojia marked this pull request as ready for review July 28, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants