Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1025: migrate from Joda Time to java.time #1361

Merged
merged 5 commits into from
Aug 30, 2020
Merged

Conversation

denisa
Copy link
Contributor

@denisa denisa commented Jul 28, 2020

use java.time.ZonedDateTime directly instead of custom Timestamp class.

This is part of migrating to java 8

denisa and others added 2 commits July 26, 2020 16:19
…e directly instead of custom Timestamp class

Signed-off-by: Denis N. Antonioli <[email protected]>
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #1361 into master will increase coverage by 0.21%.
The diff coverage is 78.57%.

@@             Coverage Diff              @@
##             master    #1361      +/-   ##
============================================
+ Coverage     56.48%   56.70%   +0.21%     
+ Complexity     1835     1817      -18     
============================================
  Files           158      158              
  Lines          8721     8659      -62     
  Branches       1340     1326      -14     
============================================
- Hits           4926     4910      -16     
+ Misses         3322     3288      -34     
+ Partials        473      461      -12     
Impacted Files Coverage Δ Complexity Δ
...ven/docker/access/hc/DockerAccessWithHcClient.java 25.55% <0.00%> (ø) 26.00 <0.00> (ø)
...o/fabric8/maven/docker/access/log/LogCallback.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...io/fabric8/maven/docker/wait/LogMatchCallback.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...io/fabric8/maven/docker/util/TimestampFactory.java 50.00% <50.00%> (ø) 2.00 <2.00> (?)
.../fabric8/maven/docker/access/log/LogRequestor.java 79.01% <100.00%> (ø) 13.00 <0.00> (ø)
...o/fabric8/maven/docker/log/DefaultLogCallback.java 82.22% <100.00%> (ø) 11.00 <0.00> (ø)
...ava/io/fabric8/maven/docker/log/LogOutputSpec.java 98.48% <100.00%> (+53.03%) 12.00 <0.00> (+4.00)
...a/io/fabric8/maven/docker/util/DockerFileUtil.java 77.14% <0.00%> (-2.30%) 20.00% <0.00%> (-14.00%)

@denisa
Copy link
Contributor Author

denisa commented Aug 3, 2020

Let me know if you want a new PR with a single commit.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

78.6% 78.6% Coverage
0.0% 0.0% Duplication

@rhuss
Copy link
Collaborator

rhuss commented Aug 30, 2020

Thanks ! Looks good, let's get it merged now

@rhuss rhuss merged commit 7a74393 into fabric8io:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants