Support for ActiveAdmin 1.0 and 1.1.0 #25
Conversation
Update from fabn fork
|
Thanks for your PR, are you interested in becoming a maintainer of this project? See #26 |
activeadmin-globalize.gemspec
Outdated
|
|
||
| s.files = Dir['{app,config,db,lib}/**/*'] + %w(MIT-LICENSE README.md) | ||
|
|
||
| s.add_dependency 'activeadmin' | ||
| s.add_dependency 'activeadmin', '>= 1.0', '< 1.1' |
There was a problem hiding this comment.
@rhymes Here you could do < 1.2 to support ActiveAdmin 1.1
|
I did try a fork of your branch with Activeadmin 1.1 and it worked fine so far:
The only problem I currently faced is that I sometimes have only a German flag and sometimes an English and a German flag for entries that, in both cases, only had an English translation. So you might consider to support ActiveAdmin 1.1 while you're at it. Please note that the background on the screenshots comes from my custom css. |
|
@besi you're right. I've allowed AA 1.1. The issue is that this branch (as the upstream branch) does not remotely pass any test on Travis :-( |
|
Thanks for your PR, since you and others reported it to work I've merged it and I'm going to release it as version I'm about to push it to rubygems. |
|
Version 1.0.0.pre is out |
No description provided.