Redirect plugin build stdout and pass to logger. #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new version has been released. You PR aligned right on time with my planned release of today 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working a local fable plugin in
Fable.CompilerI noticed that the build of the plugin was producing output in the process stdout. Which cannot happen in my vite-plugin setup.This change redirects the output and prints it via the logger. Behaviour from
Fable.Cliwould be unaltered andFable.Compilerwould not write to the stdout.Ready for review @MangelMaxime.
Could you also publish a new alpha for
Fable.Compilerwith this fix 😇?