Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set verbosity in Fable.Cli #3744

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

nojaf
Copy link
Member

@nojaf nojaf commented Feb 8, 2024

This is the easy fix for #3743.
A better fix would probably be to revisit let mutable private verbosity = Fable.Verbosity.Normal.

@nojaf
Copy link
Member Author

nojaf commented Feb 11, 2024

Hi @MangelMaxime, did you have a chance to look at this PR?

@MangelMaxime
Copy link
Member

Hello @nojaf,
I didn't run it locally but I suppose it will mimic the behaviour from before.

A better fix would probably be to revisit let mutable private verbosity = Fable.Verbosity.Normal.

I agree, for the rewrite of Fable.CLI I would like to introduce 3 levels of logging:

  • Normal/Default (the current one which rewrite the console output)
  • Verbose which log the same information as normal but without the rewrite as this is sometimes blocking things when used in conjonction with Vite.
  • Debug which is the current Verbose one which log information about project references etc.

I think it makes sense to have these 3 levels of informations as seeing Typecheck of .... messages just add a lot of noise in the output for not much benefit in a normal usage of Fable.

With that said, do you think we should postpone re-adding "debug" level of logs to when we rewrite Fable.CLI or still pursue in merging this PR?

@nojaf
Copy link
Member Author

nojaf commented Feb 12, 2024

mimic the behaviour from before.

Yup, it does, I would merge this one in just to get the original behaviour back.
We can revisit it later. Your suggestion makes sense.

@MangelMaxime
Copy link
Member

Thanks for your answer, I will include it in the next release.

@MangelMaxime MangelMaxime merged commit 806c1f7 into fable-compiler:main Feb 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New logger doesn't display the same information as before when using --verbose
2 participants