Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] datetime timespan addition works #3666

Merged
merged 5 commits into from
Dec 15, 2023
Merged

[Python] datetime timespan addition works #3666

merged 5 commits into from
Dec 15, 2023

Conversation

dbrattli
Copy link
Collaborator

@dbrattli dbrattli commented Dec 15, 2023 •
edited
Loading

Fixes a regression with DateTime and TimeSpan addition after the previous timedelta to TimeSpan refactor. This broke the Fable.Python Timeflies demo. FYI: @MangelMaxime

Also simplifies some type checking in map_util.py

@MangelMaxime MangelMaxime merged commit 394fadf into main Dec 15, 2023
13 checks passed
@MangelMaxime MangelMaxime deleted the python-datetime-timespan-addition branch December 15, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MangelMaxime MangelMaxime Awaiting requested review from MangelMaxime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbrattli @MangelMaxime