-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for joining terminals #74
Conversation
FYI: I've now realized that the TS error above will have to be silenced to be able to package the extension. |
Bravo! When will it be ready? |
It depends on when the maintainers will be able to merge this PR. I'm running the development version myself 😁 |
How can i do it as well? |
You can clone my repo, install all dependencies with |
@fabiospampinato any thoughts on this so far? |
@alextegelid You should probably make a fork and publish it, looks like Fabio does not have the time to manage this extension anymore. |
I've got a fork right here: But you'll have to build it yourself. See my comment above regarding building it. |
It looks like the linked issues got closed already, so this PR should not be relevant anymore, sorry. |
Resolves #66 and #9
Please note: This PR will introduce an error in TypeScript:
However, the code runs and I think the error is a problem with
location
not being specified in the type declaration for vscode. Thelocation
property is in the api docs here: https://code.visualstudio.com/api/references/vscode-api#TerminalOptionsThe error can be silenced by adding
//@ts-ignore
to line 143 in run.ts but I'll leave that to the maintainers.