Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for joining terminals #74

Closed
wants to merge 4 commits into from

Conversation

alextegelid
Copy link
Contributor

@alextegelid alextegelid commented Aug 5, 2022

Resolves #66 and #9

Please note: This PR will introduce an error in TypeScript:

Property 'location' does not exist on type 'TerminalOptions'.ts(2339)

However, the code runs and I think the error is a problem with location not being specified in the type declaration for vscode. The location property is in the api docs here: https://code.visualstudio.com/api/references/vscode-api#TerminalOptions

The error can be silenced by adding //@ts-ignore to line 143 in run.ts but I'll leave that to the maintainers.

@alextegelid
Copy link
Contributor Author

FYI: I've now realized that the TS error above will have to be silenced to be able to package the extension.

@JacobsonGal
Copy link

Bravo! When will it be ready?

@alextegelid
Copy link
Contributor Author

It depends on when the maintainers will be able to merge this PR. I'm running the development version myself 😁

@JacobsonGal
Copy link

How can i do it as well?

@alextegelid
Copy link
Contributor Author

You can clone my repo, install all dependencies with npm install and then build the extension following this documentation and finally install from the newly created .vsix file.

@alextegelid
Copy link
Contributor Author

@fabiospampinato any thoughts on this so far?

@Akronae
Copy link

Akronae commented Aug 31, 2022

@alextegelid You should probably make a fork and publish it, looks like Fabio does not have the time to manage this extension anymore.
I'd gladly install yours!

@alextegelid
Copy link
Contributor Author

I've got a fork right here:
https://github.com/alextegelid/vscode-terminals

But you'll have to build it yourself. See my comment above regarding building it.

@fabiospampinato
Copy link
Owner

It looks like the linked issues got closed already, so this PR should not be relevant anymore, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow spliting terminals
4 participants