-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v5 generator #179
Add v5 generator #179
Conversation
Hey, The underline idea is to keep this project as easy as possible, it’s a side project so if I don’t have to maintain multiple version of react-query, this would be amazing 😁 |
Oh I see, I will change it tomorrow and test it on our project. |
Ok, the object signature works fine, I've update the PR, feel free to add any comments to it, so I can fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I can see that pipeline failed, in repo is package lock and pipeline uses yarn, should I change package lock to yarn lock and commit? |
Oh no, wait, let’s just fix the pipeline to use the same thing |
this version works with react query 4 but fails with react query 5 ( tested with "@tanstack/react-query": "5.0.0-alpha.71" )
What did i do? |
At least this is not breaking react-query v4, sorry for bad review! |
I think this is issue of RQ, UseQueryOptions should be assignable to the useQuery hook, I've opened issue in tanstack/query TanStack/query#5696 |
Fixes #176
Added generator for react query V5