Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible Python 3.6 #244

Closed
gvmturl opened this issue Apr 3, 2020 · 11 comments · Fixed by #291
Closed

Incompatible Python 3.6 #244

gvmturl opened this issue Apr 3, 2020 · 11 comments · Fixed by #291

Comments

@gvmturl
Copy link

gvmturl commented Apr 3, 2020

Could you please update it?

Thank you for the job!

@gvmturl
Copy link
Author

gvmturl commented Apr 11, 2020

Cant use the plugin with python 3.7 any solution please?

@rlogiacco
Copy link
Collaborator

The author and his apprentices are working on this, you might want to find a way to support his efforts and show your appreciation for his donation to the community ;-)

@gvmturl
Copy link
Author

gvmturl commented Apr 20, 2020

Tried adding plugin_pythoncompat = ">=2.7,<4" on init.py of python3 branch. could make it work but the listener is not working...
ERROR: I was not able to format the Notification for 'PrinterStart' properly. Please open your OctoPrint settings for Telegram Notifications and check message settings for 'PrinterStart'.

And

I do not understand you!

Are the messages that i m receiving from bot...

Any help? Any1 could use it on python3?

Thank you guys!

@gvmturl
Copy link
Author

gvmturl commented May 1, 2020

Is there any news about the python 3 compatibility?

@szobov
Copy link
Contributor

szobov commented Jul 16, 2020

Hi there,
I've fixed python3 incompatibility in my fork: https://github.com/szobov/OctoPrint-Telegram
But I didn't prepare it for this repo, because I didn't spend time to fix it for python2.
You're welcome to check:

python -m pip install "https://github.com/szobov/OctoPrint-Telegram/archive/master.zip"

Cheers.

@MarcusWolschon
Copy link
Contributor

Can you create a pull request?

@szobov
Copy link
Contributor

szobov commented Jul 16, 2020

Can you create a pull request?

Sure, here it is:
#273

@xbarents
Copy link

Octoprint made a anncouncement for a conversion script to migratie from python 2 to 3. We can expect more questions coming because Telegram will not work anymore after running the script.

Is there any timeframe when the plugin will be updated?

@maier-johno
Copy link

Hello, i have tested it too. First, the upgrade was without errors. But my telegram-plugin don't work. And my FilamentManager-Plugin can't connect to my database on a other RasPi. So, i go back with your " https://raw.githubusercontent.com/cp2004/Octoprint-Upgrade-To-Py3/master/go_back.py" script. This works great too!

That's the only reason why i go back. But respect, both scripts works perfectly! Octoprint with Python 3.6 too!

Great job and thank's for the great scripts!

@fractalsauce
Copy link

fractalsauce commented Sep 20, 2020

Thanks for the fix @szobov :)

@FranciscodeMaussion
Copy link
Contributor

This is mandatory, for now we can use szobov solution. Thanks @szobov

szobov added a commit to szobov/OctoPrint-Telegram that referenced this issue Oct 1, 2020
szobov added a commit to szobov/OctoPrint-Telegram that referenced this issue Oct 2, 2020
szobov added a commit to szobov/OctoPrint-Telegram that referenced this issue Oct 2, 2020
szobov added a commit to szobov/OctoPrint-Telegram that referenced this issue Oct 4, 2020
szobov added a commit to szobov/OctoPrint-Telegram that referenced this issue Oct 4, 2020
szobov added a commit to szobov/OctoPrint-Telegram that referenced this issue Oct 4, 2020
szobov added a commit to szobov/OctoPrint-Telegram that referenced this issue Oct 4, 2020
giloser added a commit that referenced this issue Oct 10, 2020
[Fix #244] Fix incompatibilities with python3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants