-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications for layer height sent twice w/ Z-hop #13
Comments
On a first, very short, look it seems the "problem" lies within octoprint_telegram/init.py line 294 It returns True if the Z change to the last Z notification is greater than the configured threshold or if the new Z position is smaller than the Z position of the last notification. |
The negative Z change becomes interesting if you do something like "move to X0 Y0 Z5 and extrude some material" at the beginning of the print. Although I ignore large Z changes (anything of at least 2.0mm for now) anyway... I think removing the |
Any News on this? Having the same issue. |
This is also a problem when using Octolapse - this line causes notifications every time octolapse performs a z-hop after a snapshot. Octolapse is using relative positioning, so I think it's also messing with the storage of the last z value - but that might be from octoprint passing the relative z change as new_z in the ZChange event? Either way, all Z positions were being reported as "-0.2" in notifications. |
After a while I again enabled Octolapse and again received many telegram notifications. This Z position with „-0.2“ in notification is exactly what I observe again. Is there any progress in solving this issue ? |
…nline#13) add check to make sure that `new_z` height is always more than zero, this prevents the plugin to send the same notification twice Changes to be committed: modified: octoprint_telegram/telegramNotifications.py
This is still very annoying, and I see there are some proposed fixes, including the pending PR #423. It would be convenient if they were merged, because currently I am forced to apply the patch locally and lose the change every plugin update. |
Hey,
I have enabled Z-hop on retract (0.1mm). My plugin has the default config of notifying me every 5mm in Z oder every 15 minutes.
I wondered why I get 2 messages sent shortly after each other each time a message is sent.
Then I saw that the first message has a greater Z height than the second, mostly something like:
Since I have used a layer height of 0.15mm and a Z-hop on retract of 0.1mm and have enabled the "force retract on layer change" it would totally make sense that the plugin is triggered twice with a very short time difference.
Anything I can do to help?
OctoPint 1.2.9
OctoPrint-Telegram 1.0.0
The GCODE I printed is attached.
serenity_no_panels_sliced_top.gcode.txt
The text was updated successfully, but these errors were encountered: