Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce memory consumption for swirling flats #1222

Merged
merged 1 commit into from
Sep 9, 2024
Merged

reduce memory consumption for swirling flats #1222

merged 1 commit into from
Sep 9, 2024

Conversation

fabiangreffrath
Copy link
Owner

No description provided.

@fabiangreffrath
Copy link
Owner Author

Adapted from Woof!

JNechaevsky
JNechaevsky approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@JNechaevsky JNechaevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can see about ~100 kilobytes of memory reducing, if I'm looking correct.
So sure, even a small optimization is always valuable.

@fabiangreffrath fabiangreffrath merged commit 3ddd6fd into master Sep 9, 2024
6 checks passed
@fabiangreffrath fabiangreffrath deleted the swirl_memory branch September 9, 2024 13:31
@fabiangreffrath
Copy link
Owner Author

Should be 4 MB instead of 16 MB to store the entire sequence. Are you sure you called the initialization function?

@JNechaevsky
Copy link
Collaborator

Ah, of course, it is called when if (init_swirl), which requires ANIMATED lump with one animated flat with 65536 speed. Yes, I see the difference now, thank you! Looks likes previous approach was consuming not 16, but about ~21 megabytes, but now it's exactly 4.

Let's just don't spoil the difference of new SPEED, I can notice it, but if it's by design, let's leave it with 32 then. 🤫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JNechaevsky JNechaevsky JNechaevsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabiangreffrath @JNechaevsky