Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite template system #23

Merged
merged 38 commits into from
Mar 25, 2024
Merged

Rewrite template system #23

merged 38 commits into from
Mar 25, 2024

Conversation

alexandre-pod
Copy link
Member

@alexandre-pod alexandre-pod commented Feb 13, 2024 •
edited
Loading

This PR is an entire rewrite of the templating system, allowing customization of template and settings

peyronc
peyronc reviewed Feb 19, 2024
View reviewed changes
Copy link

@peyronc peyronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

à première vue j'ai rien vu de spécial, mais j'ai pas testé

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@alexandre-pod alexandre-pod marked this pull request as ready for review February 20, 2024 17:59
peyronc
peyronc approved these changes Mar 4, 2024
View reviewed changes
Copy link

@peyronc peyronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t'as juste les .gitKeep qui traine, mais ca c'était déjà là 😄

@alexandre-pod
Copy link
Member Author

alexandre-pod commented Mar 4, 2024 •
edited
Loading

t'as juste les .gitKeep qui traine, mais ca c'était déjà là 😄

C'est a dire les .gitKeep ? Dans les groupes générés ? Car on en a besoin pour les groupes vides, sinon les dossiers ne sont pas dans git, et Xcode marque les groupes en rouges car il ne trouve pas les dossiers dans le filesystem (après avoir récupéré les changements depuis un autre ordi).

@peyronc
Copy link

peyronc commented Mar 4, 2024

t'as juste les .gitKeep qui traine, mais ca c'était déjà là 😄

C'est a dire les .gitKeep ? Dans les groupes générés ? Car on en a besoin pour les groupes vides, sinon les dossiers ne sont pas dans git, et Xcode marque les groupes en rouges car il ne trouve pas les dossiers dans le filesystem (après avoir récupéré les changements depuis un autre ordi).

yes j'ai vu ca dans la pr d'exemple MyHPad/App/NewScreen/UI/View/.gitkeep ;)

Nooba
Nooba reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@Nooba Nooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick / typos.
J’ai pas regardé précisément le code ruby j’avoue…

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/ccios/templates/Presenter/template.yml Outdated Show resolved Hide resolved
@alexandre-pod alexandre-pod force-pushed the feature/rewrite_template_system branch from 13a3675 to 22bfc07 Compare March 5, 2024 13:02
ThibaultFarnier
ThibaultFarnier reviewed Mar 20, 2024
View reviewed changes
Copy link

@ThibaultFarnier ThibaultFarnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un mini-retour mais all good sinon

lib/ccios.rb Show resolved Hide resolved
@alexandre-pod alexandre-pod merged commit 9818d1e into master Mar 25, 2024
2 checks passed
@alexandre-pod alexandre-pod deleted the feature/rewrite_template_system branch March 25, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peyronc peyronc peyronc approved these changes

@ThibaultFarnier ThibaultFarnier ThibaultFarnier approved these changes

@Nooba Nooba Nooba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandre-pod @peyronc @Nooba @ThibaultFarnier