Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Actions upgraded from v2 to v2.3.1.3.1.3.1.3.1.3.1 instead of v2.3.1 #17

Closed
kdeldycke opened this issue Jul 1, 2020 · 4 comments · Fixed by #21
Closed

Actions upgraded from v2 to v2.3.1.3.1.3.1.3.1.3.1 instead of v2.3.1 #17

kdeldycke opened this issue Jul 1, 2020 · 4 comments · Fixed by #21
Assignees
@fabasoad
Labels
bug Something isn't working

Comments

@kdeldycke
Copy link

Describe the bug

The generated updated version of an action is repeating itself after the major revision part.

Steps to Reproduce

See my GitHub action which is trying to update all versions from all my workflows at: https://github.com/kdeldycke/awesome-iam/blob/master/.github/workflows/lint.yaml#L11-L38

This produce the following change: https://github.com/kdeldycke/awesome-iam/pull/6/files#diff-c81593a3651bf87f58345cd819edad71

in which:

- uses: actions/checkout@v2

is replaced by:

- uses: actions/[email protected]

Expected behavior

Here I expect actions/checkout@v2 to be replaced by actions/[email protected].

Actual behavior

Instead, what's happening is that actions/checkout@v2 gets replaced by actions/[email protected].
Technical information (please complete the following information):
@kdeldycke kdeldycke added the bug Something isn't working label Jul 1, 2020
@kdeldycke
Copy link
Author

Other than that bug, I'm pretty happy with ghacu, which is finding all my workflows, YAML files and actions from each job! Thanks @fabasoad for this great CLI! 👍

@fabasoad
Copy link
Owner

fabasoad commented Jul 3, 2020

@kdeldycke Thank you for bug report and for positive feedback! I'll take a look at this bug in this weekend. Also, pull requests are very welcome in case you have a time or mood to contribute 🙂

fabasoad pushed a commit that referenced this issue Jul 3, 2020
#17 - Add information to README. Fix paths in .iss files.
d325906
fabasoad pushed a commit that referenced this issue Jul 3, 2020
#17 - Testing CI with updater.
483e475
fabasoad pushed a commit that referenced this issue Jul 3, 2020
#17 - Updating PR action
232783a
fabasoad pushed a commit that referenced this issue Jul 3, 2020
#17 - Fix issue with replacement
4ac7f83
fabasoad pushed a commit that referenced this issue Jul 3, 2020
#17 - Fix issue with replacement (2)
671101f
fabasoad pushed a commit that referenced this issue Jul 3, 2020
#17 - Remove \n from regex
f152741
fabasoad pushed a commit that referenced this issue Jul 3, 2020
#17 - Upgrade 1.1.3 to 1.1.4
8f5c9ba
fabasoad pushed a commit that referenced this issue Jul 3, 2020
#17 - Upgrade actions/checkout action using latest fix
2a8ad02
@fabasoad fabasoad mentioned this issue Jul 3, 2020
Merged
14 tasks
fabasoad added a commit that referenced this issue Jul 3, 2020
@fabasoad
#17 - Add chmod permissions for ./ghacu in CI pipeline
7663fda
fabasoad added a commit that referenced this issue Jul 3, 2020
@fabasoad
#17 - Fix incorrect version replacement (#21)
d2db41d 
* #17 - Add information to README. Fix paths in .iss files.
* #17 - Testing CI with updater.
* #17 - Updating PR action
* #17 - Fix issue with replacement
* #17 - Fix issue with replacement (2)
* #17 - Remove \n from regex
* #17 - Upgrade 1.1.3 to 1.1.4
* #17 - Upgrade actions/checkout action using latest fix
* #17 - Add chmod permissions for ./ghacu in CI pipeline
@fabasoad fabasoad linked a pull request Jul 3, 2020 that will close this issue
#17 - Fix incorrect version replacement #21
Merged
14 tasks
@fabasoad
Copy link
Owner

fabasoad commented Jul 3, 2020

Fixed in v1.1.4

@fabasoad fabasoad closed this as completed Jul 3, 2020
@kdeldycke
Copy link
Author

Thanks @fabasoad for the fix!

I can confirm v1.1.4 really fix the issue.

Run ghacu --upgrade
> Sync labels (.github/workflows/labels_sync.yaml)
actions/checkout  v2  »  v2.3.1

> Lint (.github/workflows/lint.yaml)
actions/setup-dotnet                  v1.4.0  »  v1.5.0
actions/checkout                          v2  »  v2.3.1
peter-evans/create-pull-request           v2  »  v2.8.1
actions/checkout                          v2  »  v2.3.1
stefanzweifel/git-auto-commit-action      v4  »  v4.4.0
actions/checkout                          v2  »  v2.3.1
avto-dev/markdown-lint                    v1  »  v1.3.0
peter-evans/create-pull-request           v2  »  v2.8.1
avto-dev/markdown-lint                    v1  »  v1.3.0
actions/checkout                          v2  »  v2.3.1
peter-evans/create-pull-request           v2  »  v2.8.1
actions/checkout                          v2  »  v2.3.1

See:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fabasoad fabasoad

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#17 - Fix incorrect version replacement fabasoad/ghacu
2 participants
@kdeldycke @fabasoad